Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve random seed setting for all examples #243

Merged
merged 4 commits into from
Feb 15, 2018

Conversation

muupan
Copy link
Member

@muupan muupan commented Feb 15, 2018

in the same way as #239

  • ALE accepts [0,2**31), so ALE examples use [0,2**31).
  • Although gym envs accepts broader range of values, numpy.random.seed accepts [0,2**32) as a integer, so gym examples use [0,2**32).
  • Logger outputs of some examples were invisible, so I changed their logger settings.

Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit 7ab0197 into chainer:master Feb 15, 2018
@muupan muupan added this to the v0.4 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants