Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dtype arg of spaces.Box #231

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Conversation

toslunar
Copy link
Member

gym 0.9.6 added dtype arg to spaces.Box.
The PR supports the newer interface in a backward-compatible way.
The fix in chainerrl.envs removes the warnings WARN: gym.spaces.Box autodetected dtype as < ... >. Please provide explicit dtype..

@toslunar
Copy link
Member Author

I run in Python 3 the test pytest -m "not slow and not gpu" tests -x with gym versions:

  • 0.7.3 (the current requirement of ChainerRL),
  • 0.9.5,
  • 0.9.6.

@toslunar
Copy link
Member Author

Passed the tests

  • ./test_examples -1,
  • ./test_examples 0, and
  • pytest -m "not slow"

with the versions above (i.e. I tested 3×3). Ready to be reviewed.

@toslunar toslunar changed the title [WIP] Support dtype arg of spaces.Box Support dtype arg of spaces.Box Feb 13, 2018
@muupan
Copy link
Member

muupan commented Mar 15, 2018

LGTM

@muupan muupan merged commit fd8259f into chainer:master Mar 15, 2018
@muupan muupan added this to the v0.4 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants