Use pytest #209
Merged
Use pytest #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chainer v2 uses nose. It uses pytest from v3.
|
Why did coverage increase that much? > Coverage increased (+6.5%) to 79.691% |
|
It seems nosetests didn't report the coverage by subprocess. |
muupan
requested changes
Jan 26, 2018
| 'last_wscale': [1, 1e-3], | ||
| }) | ||
| ) | ||
| class TestFCSAQFunction(_TestSAQFunction): |
There was a problem hiding this comment.
This is a concrete test case, not a base test. It looks the same as TestFCSAQFunction in tests/q_functions_tests/test_state_action_q_function.py, so I think it is not necessary.
| 'last_wscale': [1, 1e-3], | ||
| }) | ||
| ) | ||
| class TestFCLSTMSAQFunction(_TestSAQFunction): |
| 'last_wscale': [1, 1e-3], | ||
| }) | ||
| ) | ||
| class TestFCBNSAQFunction(_TestSAQFunction): |
| 'last_wscale': [1, 1e-3], | ||
| }) | ||
| ) | ||
| class TestFCBNLateActionSAQFunction(_TestSAQFunction): |
|
Thanks. Fixed. |
muupan
approved these changes
Jan 26, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nosetopytest_Test*of tests to filesbasetest_*.py, becausepytestcannot ignore classes by their names, but by the filenames.