Improve MLPBN #171
Merged
Improve MLPBN #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toslunar
reviewed
Nov 15, 2017
chainerrl/links/mlp_bn.py
Outdated
| to inputs. | ||
| normalize_output (bool): If set to True, Batch Normalization is applied | ||
| to outputs. | ||
| nonlinearity (callable): Nonlinearity between layers. |
There was a problem hiding this comment.
In most cases, nonlinearity is a chainer.Function, and it cannot be a chainer.Link. Could you make the followings clear?
nonlinearityhas no parameters;nonlinearity, called with one argument ofchainer.Variable, returnschainer.Variableof the same shape as the input.
toslunar
reviewed
Nov 15, 2017
tests/links_tests/test_mlp_bn.py
Outdated
|
|
||
| import unittest | ||
|
|
||
| import numpy as np |
There was a problem hiding this comment.
In other files, numpy and chainer are in the same group of the import order.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nonlinearityandlast_wscaleargument to MLPBNThe tests for MLPBN are actually not checking each configuration is applied or not, but it should be better than having no tests.