Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Chain.init_scope in the quick start #148

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

delta2323
Copy link
Member

@delta2323 delta2323 commented Oct 9, 2017

Initialization of links with Chain.__init__ is obsolete from Chainer v2. This PR changes to use Chain.init_scope instead in the quick start. As some I ran the code to confirm it works well, some results have changed (mainly caused by the change of random seed). Let me know if it is troublesome.

@coveralls
Copy link

coveralls commented Oct 9, 2017

Coverage Status

Coverage remained the same at 71.567% when pulling 23f201b on delta2323:update-quickstart into 9c7136a on chainer:master.

@toslunar toslunar merged commit f62f460 into chainer:master Oct 10, 2017
@toslunar
Copy link
Member

LGTM

@muupan muupan added the example label Nov 30, 2017
@muupan muupan added this to the v0.3 milestone Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants