Add kitti dataset #697
Add kitti dataset #697
Conversation
debug message off
list() to [] syntax miss(iable -> label)
…_dataset # Conflicts: # docs/source/reference/datasets.rst
rename filename(add _bbox_) rename class(add Bbox) testcode use bbox_assert Fit Bbox to image area bbox, label parameter replace from list to ndarray
add gray image test
test code success testdata.(comment ng test)
check pep8(remove whitespace blank)
remove comment
|
Hi! Thank you for your PR! Some comments.
|
|
Do you know any experiments in academic papers that can be supported by this dataset? |
…_dataset # Conflicts: # environment.yml chainer cv pullrequest review point fixed. 1. lower char folders 2. add check tables 3. label shape 1 dim 4. pykitti target 0.3.0. remove glay scale logic. 5. add comment to KITTIBboxDataset class.
fixed comment.
source of a quote? I do not know about the research citing the data set. |
| ) | ||
| kitti_ignore_bbox_label_color = (0, 0, 0) | ||
|
|
||
| kitti_date_lists = ['2011_09_26', '2011_09_28', |
There was a problem hiding this comment.
Could you rename this to kitti_date_list or kitti_dates?
| kitti_date_lists = ['2011_09_26', '2011_09_28', | ||
| '2011_09_29', '2011_09_30', '2011_10_03'] | ||
|
|
||
| kitti_date_num_dicts = { |
There was a problem hiding this comment.
Could you rename this to kitti_date_num_dict?
| KITTI | ||
| ----- | ||
|
|
||
| KITTIDataset |
|
|
||
| KITTIDataset | ||
| ~~~~~~~~~~~~ | ||
| .. autoclass:: KITTIDataset |
| dataArray = [] | ||
| for cam2 in self.dataset.cam2: | ||
| data = np.asarray(cam2) | ||
| # Convert RGB to BGR |
There was a problem hiding this comment.
Shouldn't this comment be the opposite?
| dataArray = [] | ||
| for cam2 in self.dataset.cam2: | ||
| data = np.asarray(cam2) | ||
| # Convert RGB to BGR |
| ":math:`(y_{min}, x_{min}, y_{max}, x_{max})`" | ||
| :obj:`label`, scalar, :obj:`int32`, ":math:`[0, \#class - 1]`" | ||
|
|
||
| .. [#kitti_bbox_1] If :obj:`tracklet = True`, \ |
|
|
||
| When queried by an index, if :obj:`tracklet == True`, | ||
| this dataset returns a corresponding | ||
| :obj:`img, bbox, label`, a tuple of an image, bounding boxes, labels. |
There was a problem hiding this comment.
Could you make two classes: KITTIBboxDataset and KITTIImageDataset?
It is confusing that when tracklet=False, the dataset never returns unempty bounding box or label even though it is named as BboxDataset.
KITTIBboxDataset should only support 2011_09_26, and KITTIImageDataset should support all the other dates.
Also, if you don't want to, you do not need to implement KITTIImageDataset.
We have two classes for Cityscapes as well because subset of the dataset does not contain annotation.
| from chainercv.datasets.kitti.kitti_bbox_dataset import KITTIBboxDataset # NOQA | ||
| from chainercv.datasets.kitti.kitti_utils import kitti_bbox_label_colors # NOQA | ||
| from chainercv.datasets.kitti.kitti_utils import kitti_bbox_label_names # NOQA | ||
| from chainercv.datasets.kitti.kitti_utils import kitti_date_lists # NOQA |
There was a problem hiding this comment.
Do we need to expose this object at this namespace?
We only expose _label_names and _colors here.
| from chainercv.datasets.kitti.kitti_utils import kitti_bbox_label_colors # NOQA | ||
| from chainercv.datasets.kitti.kitti_utils import kitti_bbox_label_names # NOQA | ||
| from chainercv.datasets.kitti.kitti_utils import kitti_date_lists # NOQA | ||
| from chainercv.datasets.kitti.kitti_utils import kitti_date_num_dicts # NOQA |
Issue #139
use package :
pykitti package(0.2.4/0.3.0)
parseTrackletXML.py
(Methods for parsing tracklets (e.g. dataset labels),
originally created by Christian Herdtweck.)
Function :
Display labels and boxes
not implemented
Grayscale processing