Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Support list in sliceable datasets #575

Merged
merged 2 commits into from
Apr 19, 2018
Merged

Support list in sliceable datasets #575

merged 2 commits into from
Apr 19, 2018

Conversation

Hakuyume
Copy link
Member

No description provided.

@Hakuyume Hakuyume requested review from yuyu2172 and removed request for yuyu2172 April 18, 2018 10:52
@yuyu2172 yuyu2172 added this to the v0.9 milestone Apr 18, 2018
yuyu2172
yuyu2172 previously approved these changes Apr 18, 2018
View reviewed changes
@yuyu2172 yuyu2172 dismissed their stale review April 18, 2018 11:52

found a mistake in the doc

@yuyu2172
Copy link
Member

https://github.com/Hakuyume/chainercv/blob/c82dd4b5ea4460918d7c6164b9e71a55788ad714/chainercv/chainer_experimental/datasets/sliceable/getter_dataset.py#L69

Please fix the doc.

@Hakuyume
Copy link
Member Author

Hakuyume commented Apr 18, 2018 •
edited
Loading

I want to users to use tuple officially because keys returns a tuple. This PR is only for careless users.

@Hakuyume
Copy link
Member Author

Hakuyume commented Apr 18, 2018 •
edited
Loading

I'm using some list styles in #457. Perhaps, it is better to rewrite them with tuple style. I modified them.

@yuyu2172
Copy link
Member

LGTM

@yuyu2172 yuyu2172 merged commit 61f5e0a into chainer:master Apr 19, 2018
@Hakuyume Hakuyume deleted the support-list-in-sliceable-datasets branch April 19, 2018 03:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuyu2172 yuyu2172 yuyu2172 approved these changes

Assignees

@yuyu2172 yuyu2172

Labels
None yet
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
2 participants
@Hakuyume @yuyu2172