This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Add dilate and bn_kwargs to Bottleneck and ResBlock #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hakuyume |
Hakuyume
reviewed
Mar 31, 2018
| @@ -17,8 +17,12 @@ class ResBlock(PickableSequentialChain): | |||
| mid_channels (int): The number of channels of intermediate arrays. | |||
| out_channels (int): The number of channels of the output array. | |||
| stride (int or tuple of ints): Stride of filter application. | |||
| dilate (int or pair of ints): Dilation factor of filter applications. | |||
There was a problem hiding this comment.
You use tuple of ints in stride and pair of ints in dilate. If there is no difference, I prefer tuple of ints.
There was a problem hiding this comment.
Isn't pair of ints more informative?
This is used in Conv2DBNActiv.
I greped, and both descriptions are used in the library.
There was a problem hiding this comment.
Chainer uses tuple of ints, so I changed the doc to follow that.
| @@ -17,8 +17,12 @@ class ResBlock(PickableSequentialChain): | |||
| mid_channels (int): The number of channels of intermediate arrays. | |||
| out_channels (int): The number of channels of the output array. | |||
| stride (int or tuple of ints): Stride of filter application. | |||
| dilate (int or pair of ints): Dilation factor of filter applications. | |||
| :obj:`dilate=d` and :obj:`dilate=(d, d)` are equivalent. | |||
| initialW (4-D array): Initial weight value used in | |||
There was a problem hiding this comment.
initialW should be callable or initializer. (4-D array) is not good.
yuyu2172
force-pushed
the
improve-resblock
branch
from
b18bee2 to
2dfaca3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #388 (comment)