This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Add CityscapesTestImageDataset #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you resolve conflicts? |
|
Rebased to master |
yuyu2172
reviewed
Oct 6, 2017
chainercv/datasets/__init__.py
Outdated
| @@ -3,6 +3,8 @@ | |||
| from chainercv.datasets.camvid.camvid_dataset import camvid_label_names # NOQA | |||
| from chainercv.datasets.camvid.camvid_dataset import CamVidDataset # NOQA | |||
| from chainercv.datasets.cityscapes.cityscapes_semantic_segmentation_dataset import CityscapesSemanticSegmentationDataset # NOQA | |||
| from chainercv.datasets.cityscapes.cityscapes_test_image_dataset import CityscapesTestImageDataset # NOQA | |||
| from chainercv.datasets.cityscapes.cityscapes_utils import cityscapes_labels # NOQA | |||
There was a problem hiding this comment.
Can you delete this line? This may confuse users because there is not sufficient description about this object.
We are only exposing label_names and label_colors directly below chainercv.datasets.
|
|
||
| class CityscapesTestImageDataset(dataset.DatasetMixin): | ||
|
|
||
| """Dataset class for test images of `Cityscapes dataset`_. |
There was a problem hiding this comment.
Image dataset for test split of `Cityscapes dataset`_.
This is more consistent with other Image dataset (e.g. ADE20KTestImageDataset).
|
@yuyu2172 Fixed. |
|
Please add the dataset to |
|
oops, missed it. added. |
|
|
yuyu2172
previously approved these changes
Oct 6, 2017
|
Sorry. I found that the test fails. |
|
Also, I think we should add |
|
@yuyu2172 Added teardown method. |
yuyu2172
reviewed
Oct 6, 2017
| def setUp(self): | ||
| self.temp_dir = tempfile.mkdtemp() | ||
| img_dir = os.path.join( | ||
| self.temp_dir, 'leftImg8bit/{}/aachen'.format(self.split)) |
|
LGTM |
yuyu2172
approved these changes
Oct 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge #437 first.
This PR adds
CityscapesTestImageDatasetclass.