This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Use LabelDataset naming convention #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyu2172
force-pushed
the
label-dataset
branch
from
ce42b1a to
79cc343
Compare
yuyu2172
force-pushed
the
label-dataset
branch
from
79cc343 to
f7eb7f3
Compare
Hakuyume
reviewed
Sep 14, 2017
docs/source/reference/utils.rst
Outdated
| @@ -79,6 +75,10 @@ assert_is_image | |||
| ~~~~~~~~~~~~~~~ | |||
| .. autofunction:: assert_is_image | |||
|
|
|||
| assert_is_label_dataset | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
Hakuyume
reviewed
Sep 14, 2017
docs/source/reference/datasets.rst
Outdated
| @@ -3,9 +3,9 @@ Datasets | |||
|
|
|||
| .. module:: chainercv.datasets | |||
|
|
|||
| DirectoryParsingClassificationDataset | |||
| DirectoryParsingLabelDataset | |||
| ------------------------------------- | |||
There was a problem hiding this comment.
Sorry. This line should also be fixed. (the length of -)
yuyu2172
added a commit
to yuyu2172/chainercv
that referenced
this pull request
Sep 20, 2017
Hakuyume
reviewed
Sep 20, 2017
| @@ -91,8 +91,8 @@ class DirectoryParsingClassificationDataset(chainer.dataset.DatasetMixin): | |||
| --- class_1 | |||
| |-- img_0.png | |||
|
|
|||
| >>> from chainercv.dataset import DirectoryParsingClassificationDataset | |||
| >>> dataset = DirectoryParsingClassificationDataset('root') | |||
| >>> from chainercv.dataset import DirectoryParsingLabelDataset | |||
There was a problem hiding this comment.
from chainercv.dataset -> from chainercv.datasets?
|
@Hakuyume |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows discussion in #399.
ClassificationDataset has been added after updating the version to
0.6.0.Therefore, this PR is not
no-compat.