fix: deep symbol comparison #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
force-pushed
the
sn/deep-symbols
branch
from
00f8433 to
4faf434
Compare
snewcomer
force-pushed
the
sn/deep-symbols
branch
from
4faf434 to
2234e30
Compare
keithamus
approved these changes
Feb 25, 2022
Member
keithamus
left a comment
keithamus
left a comment
There was a problem hiding this comment.
Great work here @snewcomer!
My hunch is this is a minor release? We could be extra careful and release as breaking?
Contributor
Author
|
Seems like we support this API in chai (in 4.x and 5.x) so that seems right! Thanks a bunch for reviewing. Really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref chaijs/chai#1457
chaijs/chai#1054
ref #38