Make tests pass with --use_strict
#1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shvaikalesh
commented
Sep 6, 2017
| err(function(){ | ||
| function Thing(){}; | ||
| var t = new Thing(); | ||
| Thing.prototype = 1337; | ||
| t.should.be.an.instanceof(Thing); | ||
| }, expectedError, true); | ||
| }, 'The instanceof assertion needs a constructor but function was given.', true); |
There was a problem hiding this comment.
I think the message is a bit misleading: TypeError is thrown because rhs.prototype is primitive, type of rhs is OK.
keithamus
approved these changes
Sep 6, 2017
meeber
approved these changes
Sep 6, 2017
|
Should we add |
|
Not yet - we'll do a push for linting very soon though I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1034
Related to chaijs/assertion-error#9