-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: .instanceof
to allow DOM interfaces in IE11
#1008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@shvaikalesh @lucasfcosta @vieiralucas want to put a second 👍 on this? |
lib/chai/core/assertions.js
Outdated
} catch (err) { | ||
if (err instanceof TypeError) { | ||
flagMsg = flagMsg ? flagMsg + ': ' : ''; | ||
var type = constructor === null ? 'null' : typeof constructor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can do _.type(constructor)
here?
d4bb3c7
to
c107abb
Compare
@shvaikalesh Updated! |
LGTM too! Good job on that commenting explaining this change. |
Fixes #1000