test: rework tests to node-only #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long ago it seems we stopped testing in a browser, so this removes the associated switches in the test files and moves to a node-only suite. Meanwhile, this moves to using c8 for coverage and also reworks the tests to hit a local server rather than a real one (previously was hitting `chaijs.com` and another domain or two which changed underneath it over time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long ago it seems we stopped testing in a browser, so this removes the associated switches in the test files and moves to a node-only suite.
Meanwhile, this moves to using c8 for coverage and also reworks the tests to hit a local server rather than a real one (previously was hitting
chaijs.comand another domain or two which changed underneath it over time).CI is failing in main right now because of this. It was relying on external web servers for the tests to pass, and they have since changed the responses it was asserting against
@koddsson could you possibly take a look at this?
the diff is worthless i think, you're better off reading the new file by itself