Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove splash screen and fix loading issue #2731

Merged
merged 15 commits into from
Apr 7, 2024
Merged

Remove splash screen and fix loading issue #2731

merged 15 commits into from
Apr 7, 2024

Conversation

joeyballentine
Copy link
Member

The splash screen ended up being pretty easy to replace.

The splash screen getting stuck though was simply because the backend ready event was not being sent through webcontents for some reason, so the listener for it on the frontend wasn't triggering.

@RunDevelopment
Copy link
Member

Is seems like the renderer is trying to connect to the backend before realizing that it has to setup the backend on first start up.

image

The menu is active during loading. I think it would probably be best to completely hide the menu while the renderer is loading.

image

@RunDevelopment

This comment was marked as outdated.

@RunDevelopment

This comment was marked as outdated.

@joeyballentine

This comment was marked as outdated.

@RunDevelopment

This comment was marked as outdated.

@joeyballentine

This comment was marked as outdated.

@RunDevelopment

This comment was marked as outdated.

@joeyballentine
Copy link
Member Author

Honestly I don't believe you that it's this PR that caused that, but I'll look into it anyway

@joeyballentine
Copy link
Member Author

See #2748

@joeyballentine
Copy link
Member Author

Since the issue is unrelated, is this good to merge now?

@RunDevelopment
Copy link
Member

Is seems like the renderer is trying to connect to the backend before realizing that it has to setup the backend on first start up.

This is still an issue. We just can't see it with npm start or npm run dev because the renderer takes too long to show up. Make a portable zip of chainner, and this will happen for every fresh install.

@joeyballentine
Copy link
Member Author

fixed

@joeyballentine
Copy link
Member Author

nvm, its not ready. it hangs on subsequent opens... :(

@joeyballentine
Copy link
Member Author

fixed

src/renderer/main.tsx Show resolved Hide resolved
src/main/gui/main-window.ts Show resolved Hide resolved
src/renderer/main.tsx Outdated Show resolved Hide resolved
src/renderer/main.tsx Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member

fixed

I verified that it behaves correctly now. My comments are just about code quality and other minor things.

@joeyballentine joeyballentine merged commit 56e83bd into main Apr 7, 2024
20 checks passed
@joeyballentine joeyballentine deleted the no-splash branch April 7, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants