-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove splash screen and fix loading issue #2731
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Honestly I don't believe you that it's this PR that caused that, but I'll look into it anyway |
See #2748 |
Since the issue is unrelated, is this good to merge now? |
This is still an issue. We just can't see it with |
fixed |
nvm, its not ready. it hangs on subsequent opens... :( |
fixed |
I verified that it behaves correctly now. My comments are just about code quality and other minor things. |
The splash screen ended up being pretty easy to replace.
The splash screen getting stuck though was simply because the backend ready event was not being sent through webcontents for some reason, so the listener for it on the frontend wasn't triggering.