Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS universal building #2166

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Fix macOS universal building #2166

merged 2 commits into from
Aug 30, 2023

Conversation

joeyballentine
Copy link
Member

@joeyballentine joeyballentine commented Aug 30, 2023

This isn't exactly a fix, more of a workaround. The universal build both builds and signs in CI when using debug logging. Nobody can explain why, but it works. You probably think "this can't possibly be the case" except it is.

remove debug env var

i need it to run

add debug printing back
@joeyballentine joeyballentine changed the title Fix universal building Fix macOS universal building Aug 30, 2023
Copy link
Collaborator

@stonerl stonerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, let's do it. I have no idea why setting the DEBUG env works or what changes, but so be it.

@joeyballentine joeyballentine merged commit bff1cae into main Aug 30, 2023
@joeyballentine joeyballentine deleted the universal-build-testing branch August 30, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants