Update opencv and numpy #2147
Merged
Update opencv and numpy #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyballentine
changed the title
|
Are we going with a conversion function or not? I thought we agreed on that yesterday. |
|
Oh yeah, I'll do that today |
|
Btw in case you didn't see on discord, we don't need a conversion function. Mats are just ndarrays. |
joeyballentine
commented
Aug 28, 2023
joeyballentine
commented
Aug 28, 2023
joeyballentine
commented
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of numpy is basically the highest and lowest we can go without causing conflicts. Requires numba to be updated, which is included in #2146. Also requires me to fix a bunch of type issues