-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate .chn with chaiNNer on MacOS #2115
Associate .chn with chaiNNer on MacOS #2115
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Thank you @stonerl! Let's focus on |
5888b0e
to
3bcadd0
Compare
Okay, changed it. It now only associates chaiNNer with .chn files. |
3bcadd0
to
b980f07
Compare
Do we still need to other icons? |
I would let them stay. The are not copied into the app, so no harm done. And if we decide to make use of them then we already have them. |
Doesn't feel good to have unused files in the repository... No, please remove them. Let's add them when we actually add support for opening model files. |
b980f07
to
1b5e53d
Compare
Okay, removed them. |
1b5e53d
to
507ce91
Compare
Are you sure? On windows if I manually associate the file type, I'm able to open chain files directly by double clicking them. If that doesn't work on Mac, then I guess that means Mac uses different args when launching chaiNNer? |
@joeyballentine Yes, I tested it. Drag'n'drop does work, though. On macOS we need to use open-file, it seems. Can you point me to the code where the drag'n'drop and file opening, e.g., on Windows is handled? I am uncertain whether I'm able to implement this for macOS, but I would give it a try. |
Arg parsing: chaiNNer/src/main/arguments.ts Line 30 in 11a75fc
Using the arg: chaiNNer/src/main/gui/main-window.ts Line 129 in 11a75fc
I believe on windows when you open a file with a program it adds the file as a positional arg. I guess this is not the case for MacOS then |
ae9cd8e
to
fa922dd
Compare
- added association of .chn filetype with chainner on macOS - added file type icon - added open-file event for macOS This addresses chaiNNer-org#1062 but does not solve it completely, since file association only works on macOS ATM.
fa922dd
to
91e3da0
Compare
This addresses #1062 but does not solve it completely, since file association only works on macOS ATM.