Backend-defined package settings #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a settings option in the 'Advanced Tab' to allow hardware acceleration.
instead of a toggle for always dark the user can now choose between: Dark Mode / Light Mode / System
* add delete and select all to the nodes menu * use proper delete and multiselect keycode on mac
* WIP * new api * /features endpoint * New backend API * Switch to packages in the UI * Basic UI support for features * typo * UI WIP * Unified markdown handling * slight fixes * Properly throw server errors * Better error messages * Basic feature checking * Added spinner while refreshing
|
I'd rebase those broken commits out, but that causes a big merge conflict I don't want to deal with at the moment |
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
backend/src/packages/chaiNNer_pytorch/pytorch/processing/guided_upscale.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_pytorch/pytorch/processing/guided_upscale.py
Outdated
Show resolved
Hide resolved
* Basic API refactor * Make tensor cache path nullable * Minor changes * Setting components and other stuff * Only show clear cache when cache is enabled * Better type * Get rid of cache object * linter is always right
RunDevelopment
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of my settings refactor. Package settings are now defined on the backend per-package.
I wanted to open this as a draft to get some feedback on how I approached 1) the settings definitions themselves, 2) how I approached how you get settings for a package during a run, and 3) how I typed the settings (since it's impossible to do typescript-like type magic in python to do it automatically)
I have moved everything to the new settings system, but I have only modified the pytorch nodes to use the new execution options system. I am yet to do it for ncnn and onnx.