Skip to content

Promise comparison shouldn't be done with angular.equals #68

Open
@Amy-Lynn

Description

@Amy-Lynn

From the docs for angular.equals: "During a property comparison, properties of function type and properties with names that begin with $ are ignored." Since promises are storing their data in $$state, the line angular.equals(tracker.promises,options.promise) returns true even when the promises are different:

angular-promises

This means when the promise changes, the tracker might not get reset with the new promise since it thinks the promise didn't change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions