Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no longer need to check in swift_deps_index.json file and other big updates #957

Merged
merged 120 commits into from
Jun 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
120 commits
Select commit Hold shift + click to select a range
e53a8a6
Add sourceControl and fileSystem info to pkginfos.new_dependency.
cgrindel Feb 19, 2024
a6a2478
Clean up
cgrindel Feb 19, 2024
8381c64
Fix repo name.
cgrindel Feb 19, 2024
6383851
Do not write debug JSON if a path is not given.
cgrindel Feb 19, 2024
5bdc206
First pass at transitively processing local swift packages.
cgrindel Feb 19, 2024
4bc0a66
Do not generate targets list if no index is provided.
cgrindel Feb 19, 2024
531e6cc
Do not attempt to load index if not specified.
cgrindel Feb 19, 2024
d68ee17
Do not attempt to collect source info when running in swift_deps
cgrindel Feb 19, 2024
59ec962
Clean up.
cgrindel Feb 19, 2024
17584a1
Update pkg_manifest_minimal to use `from_package`.
cgrindel Mar 9, 2024
ed696ad
Compiled pkg_manifest_minimal.
cgrindel Mar 9, 2024
418885f
Remvoe commented code.
cgrindel Mar 10, 2024
cfc4f83
Ensure that we do not try to read the deps indexes. Remove the index
cgrindel Mar 10, 2024
c5511eb
Remove references to dep_indexes in pkginfo_target_deps.
cgrindel Mar 10, 2024
36f3a5c
Removed deps_indexes.
cgrindel Mar 10, 2024
b181223
Ensure that we include the transitive deps from the resolved package
cgrindel Mar 10, 2024
89bccd0
Add patch to get resources_example to work.
cgrindel Mar 10, 2024
b5f3bc3
Add ObjC modulemap to the library group. The resources_example is green.
cgrindel Mar 10, 2024
8e498cc
Fix bug in function that determines the src_type.
cgrindel Mar 10, 2024
975dd99
Checked grpc_example.
cgrindel Mar 10, 2024
14b4eaa
Remove obsolete Package.swift in grpc_example.
cgrindel Mar 10, 2024
3ed0708
Check for config package entries using the identity/name and the repo
cgrindel Mar 10, 2024
3235577
Update ios_sim to use bzlmod patch mechanism.
cgrindel Mar 10, 2024
7f69c6e
Update lottie_ios_example.
cgrindel Mar 10, 2024
72a52b9
Update messagekit_example.
cgrindel Mar 10, 2024
6d27b1c
Modify the byName logic to avoid circular dep error in nimble_example.
cgrindel Mar 10, 2024
071c85a
Update objc_code example
cgrindel Mar 10, 2024
5fa7371
Update phone_number_kit example.
cgrindel Mar 10, 2024
e7f703e
Update shake_ios_example.
cgrindel Mar 10, 2024
e76a86a
Update snapkit_example.
cgrindel Mar 10, 2024
3277842
Update soto_example.
cgrindel Mar 10, 2024
a76f680
Update stripe_example.
cgrindel Mar 10, 2024
c9964d7
Update vapor_example.
cgrindel Mar 10, 2024
1550e53
Save progress getting xcmetrics_example working.
cgrindel Mar 16, 2024
80f034f
Patch soto and soto-core.
cgrindel Mar 16, 2024
bc9ffc0
Fix dump.json and desc.json.
cgrindel Mar 16, 2024
28b9c8f
Started adding macro product support. About to refactor
cgrindel Mar 16, 2024
f9dcac2
Revert my change to how we find products.
cgrindel Mar 16, 2024
842a743
Save progress cleaning up unit tests.
cgrindel Mar 24, 2024
30d775c
Remove obsolete patch for gtmappauth
cgrindel Apr 12, 2024
bb31401
Got resources_example working again.
cgrindel Apr 12, 2024
22d371a
Add back Package.swift for grpc example.
cgrindel Apr 12, 2024
e636fc2
Clean up.
cgrindel Apr 12, 2024
0f4b780
Update tca example to use from_package().
cgrindel Apr 12, 2024
4a8feeb
Ran swift_update_pkgs.
cgrindel Apr 12, 2024
e0148f8
Use Brentley's branch with swift_compiler_plugin_group.
cgrindel Apr 12, 2024
1c1c151
Add flag to avoid hang while retrieving repositories.
cgrindel Apr 12, 2024
54cf86a
The tca_example builds.
cgrindel Apr 12, 2024
fd96b20
Remove DEBUG code.
cgrindel Apr 12, 2024
198455a
Fix swifpkg_build_files_tests.
cgrindel Apr 12, 2024
68d8c33
Save changes to pkginfos_test.bzl before deleting.
cgrindel Apr 12, 2024
3fc031e
Remove pkginfos_tests. It was not providing much value and was difficult
cgrindel Apr 12, 2024
8e80bab
Fixed pkginfo_target_deps_tests.
cgrindel Apr 12, 2024
7b40ebc
Remove the swift index files.
cgrindel Apr 13, 2024
837f6ff
Remove swift_deps START/END comments.
cgrindel Apr 13, 2024
7a9dc4c
Update bzlmod/workspace to use from_package().
cgrindel Apr 13, 2024
4a02be1
Return extension metadata to support bazel mod tidy.
cgrindel Apr 13, 2024
b233c27
Clean up.
cgrindel Apr 13, 2024
fefadda
Add swift_deps_info repository rule.
cgrindel Apr 13, 2024
4ec8c7a
Loading the swift_deps_info.json in the Gazelle plugin.
cgrindel Apr 14, 2024
7679e05
Support function call as build file declaration for exports_files().
cgrindel Apr 14, 2024
b5165b4
Add TODO.
cgrindel Apr 14, 2024
3bb6c2e
Ran tidy
cgrindel Apr 28, 2024
ecab933
Fixed merge issues.
cgrindel Apr 28, 2024
6d4f319
Generated swift_deps_info repo with a swift_deps_index rule. The
cgrindel Apr 28, 2024
b10b170
Remove Go swift/deps_info.go
cgrindel Apr 28, 2024
b6a1552
Add template for swift_deps_index CLI.
cgrindel Apr 28, 2024
db31bd4
Add create command to swift_deps_index CLI.
cgrindel Apr 28, 2024
8eaca3e
Parse PackageInfo from Starlark.
cgrindel May 4, 2024
e4ff665
Comment out flag from generator.
cgrindel May 5, 2024
5c8c1e5
Writing the swift deps index file.
cgrindel May 5, 2024
4e3b4ce
Fix visibility for the swift deps index.
cgrindel May 5, 2024
e81a3d7
Require a Swift dependency index file.
cgrindel May 5, 2024
df32493
Ensure product memberships are written and read properly.
cgrindel May 5, 2024
e0ad0ad
Clean up
cgrindel May 5, 2024
ceb5838
Remove update-repos
cgrindel May 5, 2024
da0925b
Remove swift_update_packages.
cgrindel May 5, 2024
7e97eb1
Pass identity through to Swift deps index.
cgrindel May 5, 2024
413df53
First pass fixing examples.
cgrindel May 5, 2024
04ce8de
Ensure that the product_memberships list is correct by generating it
cgrindel May 12, 2024
c229715
Fix Swift test and docs.
cgrindel May 12, 2024
05050e5
Fix symlink_example. Do not make resolved attribute mandatory.
cgrindel May 12, 2024
6b19724
Fix grpc_package_example.
cgrindel May 12, 2024
78b6ca6
First pass at updating doc.
cgrindel May 13, 2024
a8fda48
Fix bzlmod workspace.
cgrindel May 13, 2024
9538278
For product_memberships, use the desc JSON filtered by the list of
cgrindel May 14, 2024
8f6b64c
Add back arguments for swift_deps_info.
cgrindel May 14, 2024
d33f76f
Ran bazel mod tidy for pkg_manifest_minimal.
cgrindel May 14, 2024
c3e0982
Add tools/swift_deps_index files to runtime_files.
cgrindel May 14, 2024
0ab4ae9
Update docs.
cgrindel Jun 1, 2024
b6d67a9
Clean up comments.
cgrindel Jun 1, 2024
b5c0b59
Fix merge issues.
cgrindel Jun 2, 2024
ab33958
Delete commented code.
cgrindel Jun 2, 2024
41ffff9
Fix pkg_manifest_minimal clean test.
cgrindel Jun 2, 2024
028b98e
Add output to example test runners.
cgrindel Jun 2, 2024
1e6db93
Remove commented code.
cgrindel Jun 2, 2024
1406ee1
Update set_up_clean_test scripts.
cgrindel Jun 2, 2024
91a81bd
http_archive_ext_deps builds, but Gazelle plugin does not work.
cgrindel Jun 15, 2024
306ab70
Expose swift_deps_info repository rule.
cgrindel Jun 15, 2024
4b7ece0
Remove http_archive_ext_deps example.
cgrindel Jun 16, 2024
d45c12c
Update the comment for the update_build_files explaining the purpose of
cgrindel Jun 16, 2024
50ede38
Add bazel mod tidy step.
cgrindel Jun 16, 2024
d1365ff
Rand tidy.
cgrindel Jun 16, 2024
10badd4
More README.md updates.
cgrindel Jun 16, 2024
d1ef281
Ran swift package update on soto example.
cgrindel Jun 16, 2024
3472ed9
Remove commented code.
cgrindel Jun 16, 2024
03b74fe
Remove commented code.
cgrindel Jun 16, 2024
bfead9a
Try setting Xcode to 15.2.0.
cgrindel Jun 16, 2024
610fe10
Revert to 15.0.1. It did not fix the soto example.
cgrindel Jun 16, 2024
456029b
Adjust soto to only run on MacOS in CI.
cgrindel Jun 16, 2024
a1c8671
Ran tidy.
cgrindel Jun 16, 2024
a6e55f5
Ran tidy.
cgrindel Jun 21, 2024
c4278b5
Remove commented code.
cgrindel Jun 21, 2024
08be037
Refactor do...while loop.
cgrindel Jun 21, 2024
cf1b0d7
Remove obsolete comment.
cgrindel Jun 21, 2024
8d26293
Remove obsolete comment.
cgrindel Jun 21, 2024
90bb4b8
Add declare_swift_deps_info attribute.
cgrindel Jun 23, 2024
2f662ae
Update google maps example to use new mechanism.
cgrindel Jun 24, 2024
5f5e3d1
Disable the running of the iOS app.
cgrindel Jun 24, 2024
e83fdcb
Code review feedback.
cgrindel Jun 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add bazel mod tidy step.
  • Loading branch information
cgrindel committed Jun 25, 2024
commit 50ede38cadc966596c14418bc402723acb5d07ae
14 changes: 9 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,11 @@ feel free to populate the rest of the manifest so that your package works proper
manager. Just note that the Swift Gazelle plugin does not use the manifest to generate Bazel build
files, at this time.

### 4. Add Gazelle targets to `BUILD.bazel` at the root of your workspace.
### 4. Run `bazel mod tidy`.

This will update your `MODULE.bazel` with the correct `use_repo` declaration.

### 5. Add Gazelle targets to `BUILD.bazel` at the root of your workspace.

Add the following to the `BUILD.bazel` file at the root of your workspace.

Expand Down Expand Up @@ -196,30 +200,30 @@ gazelle(
)
```

### 5. Create or update Bazel build files for your project.
### 6. Create or update Bazel build files for your project.

Generate/update the Bazel build files for your project by running the following:

```sh
bazel run //:update_build_files
```

### 6. Build and test your project.
### 7. Build and test your project.

Build and test your project.

```sh
bazel test //...
```

### 7. Check-in `Package.resolved`, `swift_deps_index.json`, and `MODULE.bazel`.
### 8. Check-in `Package.resolved`, `swift_deps_index.json`, and `MODULE.bazel`.

- The `Package.resolved` file specifies that exact versions of the dependencies that were
identified.
- The `swift_deps_index.json` file contains information that is used by the Gazelle plugin and the
respository rules.

### 8. Start coding
### 9. Start coding

You are ready to start coding.

Expand Down