Create docker image for course requirements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add instructions for using docker
…o dockerize_requirements
Fix course number and tag info
Add support for downloaded data
…o dockerize_requirements
Option to build or use the off shelf version
Fix incorrect render
Dockerize requirements
|
OK, it wouldn't allow me to create another PR while one is open. So, I have pushed the fix for unicode issue with gloVe dataset. I have verified that with the change to util.py it fails and with the fix vsm.ipynb runs successfully. |
|
@ai2160 I ended up making really widespread revisions to the codebase for this term. Is it okay if I close this PR? |
|
@cgpotts - sure thing. |
Alina9
pushed a commit
to Alina9/cs224u
that referenced
this pull request
May 17, 2023
latest changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not find a public PR branch, hence creating a PR directly to original author's master branch.
Hi Chris,
You expressed interest in working on it and customizing it. So, here it is.
Also gloVe dataset has some unicode characters that need a minor fix to util.py. I will submit a seperate PR for that. I have verified the fix to work.
-Abhi