Fix API version bug #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The login URL should not include the leading v in the api version, just the numeric part. (See docs at: https://developer.salesforce.com/docs/atlas.en-us.api.meta/api/sforce_api_calls_login.htm) Including the leading v (as is the default behavior with the value "v29.0" results in salesforce returning a server_url with a version 7.0, which is being retired early next year. I've opted to leave the default value as is, to avoid changing the library's interface, and just to change the implementation to generate the correct URL.
Author
|
Also wanted to share a workaround, which is to explicitly pass a valid api_version without the leading 'v' to the Connection constructor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this library was generating requests to the soon-to-be-retired version 7 API, in spite of what the default api_version would have had me believe. I can open an issue if needed but i hope the description here makes the bug clear:
The login URL should not include the leading v in the api version, just the numeric part.
(See docs at: https://developer.salesforce.com/docs/atlas.en-us.api.meta/api/sforce_api_calls_login.htm)
Including the leading v (as is the default behavior with the value "v29.0" results in salesforce returning a server_url with a version of 7.0, which is being retired early next year. I've opted to leave the default value as is, to avoid changing the library's interface, and just to change the implementation to generate the correct URL.