Fix: example queued_interceptor_csrftoken.dart #2128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `Dio` is used on web platform, session cookie might needed. Just in this case csrf token is only handled at Headers. This examples adds 2 different `QueuedInterceptorsWrapper` and last one handles `onError` to update csrf token.
AlexV525
reviewed
Mar 8, 2024
| String? cachedCSRFToken; | ||
|
|
||
| final dio = Dio() | ||
| ..options.baseUrl = 'https://httpbin.org/' |
There was a problem hiding this comment.
OK, changed baseUrl and used mix 👍
| @@ -1,92 +1,95 @@ | |||
| import 'dart:async'; | |||
| import 'dart:convert'; | |||
| import 'dart:developer'; | |||
There was a problem hiding this comment.
Could you add the main idea and the overall flow at the top with comments?
There was a problem hiding this comment.
Yes, I added key features and a scenario too
|
Failed Not sure why did it failed after extra commit |
seunghwanly
added a commit
to seunghwanly/dio
that referenced
this pull request
Mar 13, 2024
newly forked a branch from cfug/dio to test if the test completes as before (100% passed) cfug#2128 (comment)
7 tasks
|
I think there may be a syncing issue between my old fork repository and the current cfug/dio. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
Provide a more suitable example for queued_interceptor_csrftoken.dart <!-- Write down your pull request descriptions. --> ### New Pull Request Checklist - [x] I have read the [Documentation](https://pub.dev/documentation/dio/latest/) - [x] I have searched for a similar pull request in the [project](https://github.com/cfug/dio/pulls) and found none - [x] I have updated this branch with the latest `main` branch to avoid conflicts (via merge from master or rebase) - [ ] I have added the required tests to prove the fix/feature I'm adding - [ ] I have updated the documentation (if necessary) - [x] I have run the tests without failures - [ ] I have updated the `CHANGELOG.md` in the corresponding package ### Additional context and info (if any) This example adds 2 different `QueuedInterceptorsWrapper` and the last one handles `onError` to update csrf token. --- fixes #2128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a more suitable example for queued_interceptor_csrftoken.dart
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)
This example adds 2 different
QueuedInterceptorsWrapperand the last one handlesonErrorto update csrf token.