Skip to content

Add SkipNav story and tests#473

Open
flacoman91 wants to merge 3 commits intomainfrom
rad-skip-nav
Open

Add SkipNav story and tests#473
flacoman91 wants to merge 3 commits intomainfrom
rad-skip-nav

Conversation

@flacoman91
Copy link
Collaborator

@flacoman91 flacoman91 commented Feb 6, 2026

This adds SkipNav as a story in storybook so devs know that this component exists.
The component exists in DSR and I would not have noticed it unless I looked through the code.

Changes

  • Adds a story
  • Linting

How to test this PR

  1. Look at the demo site
  2. Confirm SkipNav appears in the left panel
  3. Go to the demo component
  4. Press tab in the preview until you see the button

Screenshots

Screenshot 2026-02-06 at 7 25 39 AM Screenshot 2026-02-06 at 7 25 20 AM

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://cfpb.github.io/design-system-react/pr-previews/pr-473/

Built to branch gh-pages at 2026-02-07 00:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@flacoman91 flacoman91 force-pushed the rad-skip-nav branch 2 times, most recently from d2b1913 to 5f9d03f Compare February 6, 2026 18:32
@flacoman91 flacoman91 force-pushed the rad-skip-nav branch 2 times, most recently from 24856b1 to 898c19c Compare February 6, 2026 22:07
add doc text

linting

adds a unit test

remove button and link changes to minimize scope of PR
@natalia-fitzgerald
Copy link
Collaborator

natalia-fitzgerald commented Feb 6, 2026

@flacoman91
Thanks for adding this to the Storybook documentation!

What do you think of calling the component "Skip navigation" in the left nav and calling the first implementation "Skip to main content"? What is the use case for the custom text variation?

Screenshot 2026-02-06 at 6 20 39 PM

This is probably a good one to bring the the DS team for DS consideration since it's used on cf.gov and apps. We can submit the request next week once we iron out the request template on the DS side.

@flacoman91
Copy link
Collaborator Author

flacoman91 commented Feb 6, 2026

@flacoman91 Thanks for adding this to the Storybook documentation!

What do you think of calling the component "Skip navigation" in the left nav and calling the first implementation "Skip to main content"? What is the use case for the custom text variation?

Screenshot 2026-02-06 at 6 20 39 PM This is probably a good one to bring the the DS team for DS consideration since it's used on cf.gov and apps. We can submit the request next week once we iron out the request template on the DS side.

Skip navigation is good with me

I think it was configured to allow it. The only reason why I would make it configurable is if you want to skip to something in specific or to change the language depending on the requirements. If you want to lock it down, it would be one less thing to test

@natalia-fitzgerald
Copy link
Collaborator

@flacoman91
Maybe let's lock it down until we hear it needs to be customized? I'd generally want to align with what we do on cf.gov which is "Skip to main content."

@flacoman91
Copy link
Collaborator Author

Screenshot 2026-02-06 at 4 48 21 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants