This repository was archived by the owner on Jul 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 64
Update grunt deps to latest #528
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Umm, any ideas on this? Travis is drunk: npm ERR! peerinvalid The package grunt@1.0.1 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer grunt-autoprefixer@3.0.4 wants grunt@>=0.4.2
npm ERR! peerinvalid Peer grunt-banner@0.6.0 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer grunt-contrib-concat@1.0.1 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer load-grunt-tasks@3.5.2 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer grunt-legacssy@0.4.0 wants grunt@~0.4.0
npm ERR! peerinvalid Peer grunt-contrib-jshint@1.1.0 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer grunt-concurrent@2.3.1 wants grunt@>=0.4.0 |
Member
Author
|
Figured it out, has to be newer node on Travis. |
Contributor
|
I've never seen this before: Running "cssmin:main" (cssmin) task
>> Skipping remote @import of "//fast.fonts.net/t/1.css?apiType=css&projectid=44e8c964-4684-44c6-a6e3-3f3da8787b50" as no protocol given.
>> 1 file created. 187.58 kB → 144 kBBut the build completes fine. |
Member
Author
|
@Scotchester yeah just noticed that. Should I add |
Contributor
|
@anselmbradford I dunno. I feel like if always using HTTPS were not a problem, we would have already done that. |
Member
Author
Member
Author
|
@Scotchester actually hold up. That borks the css when running |
Member
Author
|
@Scotchester okay, I downgraded cssmin for now. Can you give it a try again? Thanks! |
Contributor
|
Looks good now! |
Scotchester
approved these changes
Sep 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by updating autoprefixer so it prefixes the
appearanceCSS property so the select drop-downs aren't rounded on /page-components/form-fields.html.Changes
Testing
git checkout update_gruntnpm install && gruntshould work.Notes