Skip to content
This repository was archived by the owner on Jul 10, 2020. It is now read-only.

Conversation

@anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Sep 22, 2017

Inspired by updating autoprefixer so it prefixes the appearance CSS property so the select drop-downs aren't rounded on /page-components/form-fields.html.

Changes

  • Updates grunt dependencies to latest.
  • Update node on Travis to 8.

Testing

  • git checkout update_grunt
  • npm install && grunt should work.

Notes

@anselmbradford
Copy link
Member Author

Umm, any ideas on this? Travis is drunk:

npm ERR! peerinvalid The package grunt@1.0.1 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer grunt-autoprefixer@3.0.4 wants grunt@>=0.4.2
npm ERR! peerinvalid Peer grunt-banner@0.6.0 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer grunt-contrib-concat@1.0.1 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer load-grunt-tasks@3.5.2 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer grunt-legacssy@0.4.0 wants grunt@~0.4.0
npm ERR! peerinvalid Peer grunt-contrib-jshint@1.1.0 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer grunt-concurrent@2.3.1 wants grunt@>=0.4.0

@anselmbradford
Copy link
Member Author

Figured it out, has to be newer node on Travis.

@Scotchester
Copy link
Contributor

I've never seen this before:

Running "cssmin:main" (cssmin) task
>> Skipping remote @import of "//fast.fonts.net/t/1.css?apiType=css&projectid=44e8c964-4684-44c6-a6e3-3f3da8787b50" as no protocol given.
>> 1 file created. 187.58 kB → 144 kB

But the build completes fine.

@anselmbradford
Copy link
Member Author

@Scotchester yeah just noticed that. Should I add https: to it?

@Scotchester
Copy link
Contributor

@anselmbradford I dunno. I feel like if always using HTTPS were not a problem, we would have already done that.

@anselmbradford
Copy link
Member Author

@anselmbradford
Copy link
Member Author

@Scotchester actually hold up. That borks the css when running npm start.

@anselmbradford
Copy link
Member Author

@Scotchester okay, I downgraded cssmin for now. Can you give it a try again? Thanks!

@Scotchester
Copy link
Contributor

Looks good now!

@anselmbradford anselmbradford merged commit de10e99 into gh-pages Sep 28, 2017
@anselmbradford anselmbradford deleted the update_grunt branch September 28, 2017 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants