Skip to content

Comments

Remove pinned requests package#7672

Merged
chosak merged 2 commits intomainfrom
deprecate/pinned-requests
Apr 19, 2023
Merged

Remove pinned requests package#7672
chosak merged 2 commits intomainfrom
deprecate/pinned-requests

Conversation

@chosak
Copy link
Member

@chosak chosak commented Apr 19, 2023

We currently pin requests to version 2.27.1. This was last bumped in May of 2022 in 24808f0. Over time its version has been incremented a few times.

Currently if you run tox you see an error like this:

/home/runner/work/consumerfinance.gov/consumerfinance.gov/.tox/unittest/lib/python3.8/site-packages/requests/init.py:102: RequestsDependencyWarning: urllib3 (1.26.15) or chardet (5.1.0)/charset_normalizer (2.0.12) doesn't match a supported version!

For example, a recent GHA run:

https://github.com/cfpb/consumerfinance.gov/actions/runs/4737203702/jobs/8409716743

I'm not entirely sure why this started showing up now, but it seems to have to do with psf/requests#6261.

Removing our requests pin seems to work fine.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

We currently pin requests to version 2.27.1. This was last bumped in
May of 2022 in 24808f0. Over time its
version has been incremented a few times.

Currently if you run tox you see an error like this:

> /home/runner/work/consumerfinance.gov/consumerfinance.gov/.tox/unittest/lib/python3.8/site-packages/requests/__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.15) or chardet (5.1.0)/charset_normalizer (2.0.12) doesn't match a supported version!

For example, a recent GHA run:

https://github.com/cfpb/consumerfinance.gov/actions/runs/4737203702/jobs/8409716743

I'm not entirely sure why this started showing up now, but it seems to
have to do with psf/requests#6261.

Removing our requests pin seems to work fine.
@chosak chosak requested a review from willbarton April 19, 2023 13:08
@chosak chosak marked this pull request as ready for review April 19, 2023 13:08
@chosak chosak added this pull request to the merge queue Apr 19, 2023
Merged via the queue into main with commit 9f0c4ec Apr 19, 2023
@chosak chosak deleted the deprecate/pinned-requests branch April 19, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants