DATAP-1830 - Update package deps, fix dependabot nags #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flacoman91
force-pushed
the
DATAP-1830-dependabot-fixes
branch
from
ccd7acc to
9279520
Compare
update jsdoc nags clenaup revert engine version update dist
flacoman91
force-pushed
the
DATAP-1830-dependabot-fixes
branch
from
9279520 to
a9cad30
Compare
| * @param {string|number} value - input val to check | ||
| * @param {string} field - key of the query object we need to validate | ||
| * @returns {string|number|*} valid value | ||
| * @returns {string|number|unknown} valid value |
Member
There was a problem hiding this comment.
Minor: Should this be undefined instead of unknown?
anselmbradford
approved these changes
Sep 23, 2025
Contributor
Author
|
Yeah, I think the linter was complaining that it can't be a wildcard.
All of those typedefs will go away when we switch to typescript
…On Tue, Sep 23, 2025, 7:48 AM Ans ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/utils/reducers.js
<#593 (comment)>:
> @@ -10,7 +10,7 @@ import { getSubLens } from './trends';
*
* @param {string|number} value - input val to check
* @param {string} field - key of the query object we need to validate
- * @returns {string|number|*} valid value
+ * @returns {string|number|unknown} valid value
Minor: Should this be undefined instead of `unknown?
—
Reply to this email directly, view it on GitHub
<#593 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5PYTECSP2647JH47SWM33UFMUHAVCNFSM6AAAAACG5HYIYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENJYGM4DGNRXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: DATAP-1830
This PR:
fixes the many dependabot nags:
https://github.com/cfpb/ccdb5-ui/security/dependabot/4
https://github.com/cfpb/ccdb5-ui/security/dependabot/40
https://github.com/cfpb/ccdb5-ui/security/dependabot/7
https://github.com/cfpb/ccdb5-ui/security/dependabot/6
Removes leftover junk packages from the create-react-app to rsbuild migration
Update package dependencies
Update jsdoc
Nothing changed. here's the app running on my local cfgov docker rig: