Skip to content

Conversation

@willbarton
Copy link
Member

This change adds basic workflow templates for cf.gov satellite apps frontend and backend CI and releases, Python libraries, and MkDocs publishing to GitHub.

It also adds a README with some basic information about how to use the templates and what they are.

This change adds basic workflow templates for cf.gov satellite apps frontend and backend CI and releases, Python libraries, and MkDocs publishing to GitHub.

It also adds a README with some basic information about how to use the templates and what they are.
Comment on lines +17 to +20
## consumerfinance.gov-specific workflow templates

- [cfgov-frontend-ci.yml](workflow-templates/cfgov-frontend-ci.yml): A frontend CI workflow template for cf.gov satellite apps.
- [cfgov-python-satellite-ci.yml](workflow-templates/cfgov-python-satellite-ci.yml): A backend CI workflow template for cf.gov satellite apps based on tox.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you think about reframing these as general front-end/back-end CI workflows? They offer what we would consider to be best practices for any CFPB project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that...it felt somewhat presumptuous to me to do that (at least on the backend because it presupposes Python).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can word it in such a way that it doesn't. Maybe instead of calling them frontend/backend, it should be JavaScript/Python?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Scotchester looking at this again, I'm fine moving cfgov-frontend-ci to cfpb-javascript-ci, but I think I'd like to keep the distinction between cfgov satellites and Python libraries, even if the only difference is the default of including Django in the tox matrix.

@willbarton willbarton merged commit a00e519 into main Aug 12, 2020
@willbarton willbarton deleted the workflow-templates branch August 12, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants