Added pure ES6 class and changed 4 things #68
Open
kristofzerbe wants to merge 3 commits intocferdinandi:masterfrom
Open
Added pure ES6 class and changed 4 things #68kristofzerbe wants to merge 3 commits intocferdinandi:masterfrom
kristofzerbe wants to merge 3 commits intocferdinandi:masterfrom
Conversation
Owner
|
Thanks for this. Bouncer is in need of an update for sure. I have a new design pattern I'm using, and will likely port many of these updates into the rewrite at some point. Keeping this open and unmerged for a bit as I plan next steps. |
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to my needs, I ported bouncer to a separate ES6 class and did following feature changes: