Minor json-change

[estenberg]

...pty string (php expects keys to be there)

[sigurdteigen]

I disagree with this change. NULL strings are not empty strings - it is not good practice to magically convert them inside of Json. We already had this discussion with Biswha in Oslo who wanted to do the same thing.

[estenberg]

Ok, let's create a wrapper instead then.
Otherwise we would have to do something like

if(record->classRxInclude)
{
JsonObjectAppendString(role_entry, LABEL_ROLE_CLASSRX_INCLUDE,
record->classRxInclude);
}
if(record->classRxExclude)
{
JsonObjectAppendString(role_entry, LABEL_ROLE_CLASSRX_EXCLUDE,
record->classRxExclude);
}
if(record->bundleRxInclude)
{
JsonObjectAppendString(role_entry, LABEL_ROLE_BUNDLERX_INCLUDE,
record->bundleRxInclude);
}
if(record->bundleRxExclude)
{
JsonObjectAppendString(role_entry, LABEL_ROLE_BUNDLERX_EXCLUDE,
record->bundleRxExclude);
}

(pretty much) everywhere we use it, which is verbose and error-prone.

On 27/02/12 15:17, Sigurd Teigen wrote:

I disagree with this change. NULL strings are not empty strings - it is not good practice to magically convert them inside of Json. We already had this discussion with Biswha in Oslo who wanted to do the same thing.

---

Reply to this email directly or view it on GitHub:
#7 (comment)

Eystein

[sigurdteigen]

Yes, a wrapper function would be the way to do it, e.g. JsonObjectAppendPHPString().

[estenberg]

Agreed, will revert & fix.