ENT-13303: Fixed booleans for classes in augments #6024
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victormlg
force-pushed
the
boolclassesaguments
branch
from
bd8e22a to
657aa1d
Compare
larsewi
reviewed
Jan 21, 2026
| OpenLog(default_facility); | ||
| SetSyslogFacility(default_facility); | ||
|
|
||
| EvalContextClassPutHard(ctx, "any", "source=agent"); |
Contributor
There was a problem hiding this comment.
Please explain why this is redundant in the commit message. It's not clear from looking at the diff.
Contributor
Author
There was a problem hiding this comment.
The hard class is already defined in DetectEnvironment so It feels redundant to define in generic_agent.c as well. Also sysinfo.c is where most hard class and special vars are defined already
Contributor
There was a problem hiding this comment.
I meant please explain why this is redundant in the commit message for the sake of the commit history.
Ticket: ENT-13303 Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
boolclassesaguments
branch
from
657aa1d to
f670d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.