Skip to content

Conversation

@victormlg
Copy link
Contributor

No description provided.

@victormlg victormlg force-pushed the calling_bundle branch 3 times, most recently from 85d068f to 8410fcf Compare December 8, 2025 08:17
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM 🚀

BundleBanner(bp, args);
EvalContextSetBundleArgs(ctx, args);
EvalContextStackPushBundleFrame(ctx, bp, args, a->inherit);
EvalContextStackPushBundleFrame(ctx, bp, args, a->inherit, PromiseGetBundle(pp));

Check notice

Code scanning / CodeQL

Pointer argument is dereferenced without checking for NULL Note

Parameter a in VerifyMethod() is dereferenced without an explicit null-check
@victormlg victormlg force-pushed the calling_bundle branch 2 times, most recently from 0928a30 to b16e697 Compare December 18, 2025 13:13
@victormlg victormlg requested a review from larsewi December 18, 2025 13:54
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@larsewi
Copy link
Contributor

larsewi commented Dec 19, 2025

Looks like there are some conflicts with the master branch

Ticket: ENT-12724
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants