Skip to content

Conversation

@craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Nov 4, 2025

  • Added fallback selinux script to label binaries as unconfined in case the cfengine-enterprise module fails to install

together
cfengine/buildscripts#2019
#5934

@cf-bottom
Copy link

Thanks for submitting a pull request! Maybe @larsewi can review this?

@craigcomstock craigcomstock force-pushed the ent-12980/master branch 5 times, most recently from d1682f3 to 0598797 Compare November 12, 2025 20:45
… the cfengine-enterprise module fails to install

In case the normal cfengine-enterprise policy module fails to install the scripts will run this new scripts to ensure that CFEngine can function even if SELinux is enforcing by labeling them as bin_t aka unconfined.

Ticket: ENT-12980
Changelog: title
@craigcomstock craigcomstock marked this pull request as ready for review November 13, 2025 19:24
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise.

do
semanage fcontext -a -t bin_t "$binary"
done
restorecon -iR "$_prefix"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also provide a script to revert this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm... right. I was thinking there might need to be a few layers of undo/fixup. I will address these as soon as I have an initial "good test" manually with the current bits in the 3.24 PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants