Fixes to handling of brew and compiling on macOS in GH Actions#5744
Merged
olehermanse merged 3 commits intocfengine:masterfrom Mar 28, 2025
Merged
Fixes to handling of brew and compiling on macOS in GH Actions#5744olehermanse merged 3 commits intocfengine:masterfrom
olehermanse merged 3 commits intocfengine:masterfrom
Conversation
Member
olehermanse
commented
Mar 28, 2025
olehermanse
commented
- Upgraded libntech
- CFE-4385: Fix build on macOS
- GH Actions: Installed libyaml on macOS to fix build errors
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Check for Homebrew if we're on Darwin and use brew's --prefix. Ticket: CFE-4385
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Member
Author
|
@cf-bottom jenkins, please |
Closed
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11926/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11926/ |
craigcomstock
approved these changes
Mar 28, 2025
olehermanse
added
the
cherry-pick?
Contributor
|
Needed the libyaml addition for #5780 so handling cherry picks here. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.