Default Fedora release for static checks to 37 #5126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hint: search for error: in https://ci.cfengine.com/job/static-checks/3175/console |
Otherwise static checks complain that we might access unitialized data after a cryptic for-loop that, among a ton of other things, initializes the array items.
Some parts of our codebase are just a bit too much for cppcheck and the new versions are brave/naive enough to try to get some sense of them.
vpodzime
force-pushed
the
master-f37_static_checks
branch
from
1b70dde to
af868f5
Compare
1. Do nothing if an empty string is given just like if NULL is given. 2. Pass maxlen - 1 as the length of the cipher_list string because maxlen is strlen(cipher_list) + 1. 3. Initialize the ciphers and cipher_suites strings before we append to them. These also make static checkers happy about the code.
A new, recently released version of Fedora with up to date versions of build tools finding new issues in the codebase.
vpodzime
force-pushed
the
master-f37_static_checks
branch
from
af868f5 to
a64c45b
Compare
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/9395/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9395/ |
nickanderson
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new, recently released version of Fedora with up to date versions of build tools finding new issues in the codebase.
TODO: