Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-3415: Fixed some more sign-compare warnings #4458

Merged
merged 1 commit into from
Jan 28, 2021
Merged

CFE-3415: Fixed some more sign-compare warnings #4458

merged 1 commit into from
Jan 28, 2021

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Jan 15, 2021

No description provided.

vpodzime
vpodzime reviewed Jan 18, 2021
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to not rely on errno after calling strtoul(). Let implement a StringToUlong() function that would use strtoul() and in case of strtoul() returns 0 it would check if the string was "0" (or any number of zeroes).

cf-agent/files_editline.c Outdated Show resolved Hide resolved
cf-agent/verify_users_pam.c Outdated Show resolved Hide resolved
libpromises/dbm_lmdb.c Outdated Show resolved Hide resolved
@larsewi larsewi changed the title CFE-3415: Fixed some more sign-compare warnings WIP CFE-3415: Fixed some more sign-compare warnings Jan 19, 2021
@larsewi larsewi added the WIP Work in Progress label Jan 19, 2021
@cfengine cfengine deleted a comment from lgtm-com bot Jan 22, 2021
@larsewi larsewi removed the WIP Work in Progress label Jan 22, 2021
@larsewi larsewi changed the title WIP CFE-3415: Fixed some more sign-compare warnings CFE-3415: Fixed some more sign-compare warnings Jan 22, 2021
@larsewi
Copy link
Contributor Author

larsewi commented Jan 22, 2021

@cf-bottom jenkins, please!

@cfengine cfengine deleted a comment from lgtm-com bot Jan 22, 2021
@larsewi larsewi requested a review from vpodzime January 22, 2021 12:10
@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/6062/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-6062/

@cfengine cfengine deleted a comment from lgtm-com bot Jan 22, 2021
@larsewi larsewi force-pushed the CFE-3415+ branch 4 times, most recently from 6ec6b23 to 668874a Compare January 25, 2021 09:18
@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2021

This pull request fixes 15 alerts when merging 668874a89e34a14d8cb7a04c92009144ce613824 into 2f27a1c - view on LGTM.com

fixed alerts:

  • 15 for Pointer argument is dereferenced without checking for NULL

@cfengine cfengine deleted a comment from lgtm-com bot Jan 25, 2021
@cfengine cfengine deleted a comment from lgtm-com bot Jan 25, 2021
vpodzime
vpodzime reviewed Jan 26, 2021
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise. Thanks for so many nice changes!!! 👏

cf-agent/files_editline.c Outdated Show resolved Hide resolved
libpromises/evalfunction.c Outdated Show resolved Hide resolved
@larsewi
Fixed some more sign-compare warnings
5230a28 
Changelog: Title
Ticket: CFE-3415
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi requested a review from vpodzime January 27, 2021 12:55
@lgtm-com
Copy link

lgtm-com bot commented Jan 27, 2021

This pull request fixes 15 alerts when merging 5230a28 into eefee53 - view on LGTM.com

fixed alerts:

  • 15 for Pointer argument is dereferenced without checking for NULL

vpodzime
vpodzime approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@olehermanse olehermanse merged commit 1cb68a8 into cfengine:master Jan 28, 2021
@larsewi larsewi deleted the CFE-3415+ branch February 12, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime approved these changes

@olehermanse olehermanse Awaiting requested review from olehermanse

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larsewi @cf-bottom @vpodzime @olehermanse