Skip to content

CFE-2686: Policy function format() no longer truncates strings lager than 4KiB #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 17, 2020
Merged

CFE-2686: Policy function format() no longer truncates strings lager than 4KiB #4429

merged 5 commits into from
Dec 17, 2020

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Dec 15, 2020

No description provided.

@olehermanse
Copy link
Member

@nickanderson please review policy file / test.

@olehermanse
Copy link
Member

@cf-bottom jenkins, please.

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/5994/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5994/

olehermanse
olehermanse previously approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just some smaller comments.

vpodzime
vpodzime reviewed Dec 16, 2020
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise. Thanks for the code quality improvements!

@larsewi
Added edge case test files for acceptance test
8b1fa7f 
Ticket: CFE-2686
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi force-pushed the CFE-2686 branch 3 times, most recently from 1d5bc9a to 147d345 Compare December 16, 2020 10:49
@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2020

This pull request fixes 7 alerts when merging 147d345d7334affc4bf85ffa7b3115e10ec594b6 into 368d737 - view on LGTM.com

fixed alerts:

  • 6 for Commented-out code
  • 1 for Pointer argument is dereferenced without checking for NULL

@cfengine cfengine deleted a comment from lgtm-com bot Dec 16, 2020
@cfengine cfengine deleted a comment from lgtm-com bot Dec 16, 2020
@cfengine cfengine deleted a comment from lgtm-com bot Dec 16, 2020
@larsewi
Policy function format() no longer truncates strings lager than 4KiB
11ec249 
Changelog: Title
Ticket: CFE-2686
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
Removed commented out code
bf07932 
Ticket: CFE-2686
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
Added explicit comparisons
fe22f4f 
Ticket: CFE-2686
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2020

This pull request fixes 8 alerts when merging f5acce2d57ebd7713bfcaf9470a21a19a3e48434 into 368d737 - view on LGTM.com

fixed alerts:

  • 6 for Commented-out code
  • 2 for Pointer argument is dereferenced without checking for NULL

olehermanse
olehermanse reviewed Dec 16, 2020
View reviewed changes
@larsewi
Removed snprintf and assigned a string literal instead
0043008 
Ticket: CFE-2686
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@olehermanse
Copy link
Member

@cf-bottom jenkins, please.

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/5996/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5996/

olehermanse
olehermanse approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, awaiting CI.

@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2020

This pull request fixes 8 alerts when merging 0043008 into 368d737 - view on LGTM.com

fixed alerts:

  • 6 for Commented-out code
  • 2 for Pointer argument is dereferenced without checking for NULL

@olehermanse olehermanse merged commit 7c3ba84 into cfengine:master Dec 17, 2020
@olehermanse olehermanse added the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label Dec 17, 2020
@olehermanse
Copy link
Member

Cherry-picks:
#4431
#4432

@olehermanse olehermanse removed the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label Dec 17, 2020
@larsewi larsewi deleted the CFE-2686 branch February 12, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime left review comments

@olehermanse olehermanse olehermanse approved these changes

@nickanderson nickanderson Awaiting requested review from nickanderson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larsewi @olehermanse @cf-bottom @vpodzime