Changed several functions to be bool-correct #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cf-bottom jenkins with exotics |
This fixes almost all remaining alerts for bool correctness in return values. The remaining cases are non-trivial, and warrant their own investigation and commits. Also made some smaller style changes in surrounding code. (Assertions, formatting, parentheses, comments). Reported by LGTM: https://lgtm.com/rules/1508604166004/ Changelog: None Ticket: None Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/2307/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-2307/ |
|
This pull request introduces 4 alerts and fixes 123 when merging 34c6dd3 into 3c4d046 - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes almost all remaining alerts for bool
correctness in return values. The remaining cases are
non-trivial, and warrant their own investigation and
commits.
Also made some smaller style changes in surrounding code.
(Assertions, formatting, parentheses, comments).
Reported by LGTM:
https://lgtm.com/rules/1508604166004/
Merge together:
#3726
https://github.com/cfengine/enterprise/pull/528