Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed most code analysis alerts in verify_packages.c #3703

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Fixed most code analysis alerts in verify_packages.c #3703

merged 3 commits into from
Jun 18, 2019

Conversation

olehermanse
Copy link
Member

No description provided.

@olehermanse
Added explicit null checks in verify_packages
ac74c6e 
Reported by LGTM:
https://lgtm.com/rules/1508612286000/

Changelog: None
Ticket: None
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse olehermanse added the lgtm Fixes for issues found by LGTM code analysis label Jun 18, 2019
@olehermanse olehermanse requested a review from vpodzime June 18, 2019 08:33
@olehermanse
Removed unnecessary switches in verify_packages
7a79efe 
Reported by LGTM:
https://lgtm.com/rules/2151881029/

Changelog: None
Ticket: None
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse
Whitespace
2608237 
Changelog: None
Ticket: None
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse
Copy link
Member Author

@cf-bottom jenkins

vpodzime
vpodzime approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/2679/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-2679/

@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2019

This pull request fixes 91 alerts when merging 2608237 into 7d750ee - view on LGTM.com

fixed alerts:

  • 89 for Pointer argument is dereferenced without checking for NULL
  • 1 for Long switch case
  • 1 for No trivial switch statements

@olehermanse olehermanse merged commit 920b823 into cfengine:master Jun 18, 2019
@olehermanse olehermanse deleted the null_checks branch June 18, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime approved these changes

Assignees
No one assigned
Labels
lgtm Fixes for issues found by LGTM code analysis
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olehermanse @cf-bottom @vpodzime