ENT-4681: Test proper scoping of classes defined from non-default namespace #3689
Conversation
|
Thanks for submitting a PR! Maybe @vpodzime can review this? |
| expression => "any", | ||
| scope => "bundle"; # Bundle scoped classes are NOT visible from other bundles | ||
| } | ||
| body file control { namespace => "default"; } |
There was a problem hiding this comment.
What is this double body file control supposed to do? And what makes you think it should be like that?
There was a problem hiding this comment.
The first one set the namespace to test, the second one returned the namespace to default. So bundle agent example is in the test namespace but bundle agent test is in the default namespace.
There was a problem hiding this comment.
Please fix the typos. Also, is there a ticket for this issue?
ACK, and yes, ENT-4681 is the related ticket
There was a problem hiding this comment.
I am quite surprised that the double body file control just works like this, sequentially. That looks almost like a crime! 😉
There was a problem hiding this comment.
I agree with @vpodzime this looks insane to me. The ordering of bodies and bundles within a file shouldn't matter, at all. Also a body file control is the control body for the file no? It should be for the whole file. I would expect the last body to overwrite the attributes of the first one, or an error.
There was a problem hiding this comment.
Yeah, but this is how it was designed.
https://docs.cfengine.com/docs/3.12/reference-components-file_control_promises.html
This directive can be given multiple times within any file, outside of body and bundle definitions.
tests/acceptance/00_basics/04_bundles/agent-bundle-class-bundle-scope-default-perspective.cf
Outdated
Show resolved
Hide resolved
tests/acceptance/00_basics/04_bundles/agent-bundle-class-bundle-scope-namespace-perspective.cf
Outdated
Show resolved
Hide resolved
nickanderson
changed the title
Ticket: ENT-4681 Changelog: none
nickanderson
force-pushed
the
ENT-4681/master
branch
from
dbd6610 to
2d17459
Compare
|
@cf-bottom jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/2745/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-2745/ |
No description provided.