Set map->load to 0 at the end of HashMapClear() #3594
Conversation
|
Thanks for submitting a pull request! Maybe @olehermanse can review this? |
|
Where's the unit test? :) |
Yeah, I think I will add something. It might be a bit tricky, though, the |
|
@cf-bottom jenkins with exotics, please |
|
Sure, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/2299/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-2299/ |
Otherwise the size is unchanged and the map thinks it still has all the items that were there before. The items are gone, but when new ones are inserted, the table sooner or later hits the threshold and grows automatically. Repeat this process of "insert a couple hundred items, clear, repeat" multiple times and the table grows and grows...and grows. Let's decrement map->load everytime we remove an item and assert that it reaches 0 when all items are removed. Ticket: CFE-3032 Changelog: Fix growing memory footprint of daemons
vpodzime
force-pushed
the
master-fix_growing_memory
branch
from
244bc2b to
09e5d24
Compare
|
@cf-bottom jenkins with exotics again, please |
|
Sure, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/2301/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-2301/ |
|
@cf-bottom jenkins with exotics, AGAIN, please |
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/2306/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-2306/ |
All green except for the aborted deployment tests. |
Otherwise the size is unchanged and the map thinks it still has
all the items that were there before. The items are gone, but
when new ones are inserted, the table sooner or later hits the
threshold and grows automatically. Repeat this process of "insert
a couple hundred items, clear, repeat" multiple times and the
table grows and grows...and grows.
Ticket: CFE-3032
Changelog: Fix growing memory footprint of daemons