CFE-2886: Changed cfPS to take Attributes *

[olehermanse]

This big struct shouldn't be copied by value
when not necessary.

Reported by LGTM:
https://lgtm.com/rules/2163210742/

Merge together:
#3276
https://github.com/cfengine/enterprise/pull/435

[cf-bottom]

Thanks for submitting a PR! Maybe @vpodzime can review this?

[codecov]

Codecov Report

Merging #3276 into master will decrease coverage by <.01%.
The diff coverage is 31.19%.

@@            Coverage Diff             @@
##           master    #3276      +/-   ##
==========================================
- Coverage   61.86%   61.86%   -0.01%     
==========================================
  Files         210      210              
  Lines       46425    46426       +1     
==========================================
- Hits        28722    28720       -2     
- Misses      17703    17706       +3

Impacted Files	Coverage Δ
cf-agent/verify_storage.c	41.61% <ø> (ø)	⬆️
cf-agent/verify_users.c	97.05% <ø> (ø)	⬆️
cf-agent/verify_environments.c	0% <ø> (ø)	⬆️
cf-agent/nfs.c	30.08% <0%> (ø)	⬆️
cf-agent/vercmp.c	80.76% <0%> (ø)	⬆️
cf-agent/verify_acl.c	50.93% <0%> (ø)	⬆️
libpromises/verify_classes.c	68.83% <0%> (ø)	⬆️
cf-agent/files_editxml.c	66.93% <10.11%> (ø)	⬆️
cf-agent/files_changes.c	82.12% <100%> (ø)	⬆️
libpromises/eval_context.c	86.76% <100%> (+0.01%)	⬆️
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea2a2d...81806a1. Read the comment docs.

[olehermanse]

@cf-bottom Could you test this in jenkins ? :)

[cf-bottom]

Alright, I triggered a build:

https://ci.cfengine.com/job/pr-pipeline/1187/

[vpodzime]

ACK