Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-12414: Added librsync to deps-packaging #1520

Merged
merged 2 commits into from
Dec 13, 2024
Merged

ENT-12414: Added librsync to deps-packaging #1520

merged 2 commits into from
Dec 13, 2024

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Nov 7, 2024 •
edited
Loading

Build Status

@larsewi larsewi changed the title Added librsync to deps-packaging WIP: Added librsync to deps-packaging Nov 7, 2024
@larsewi larsewi force-pushed the librsync branch 4 times, most recently from 101559b to 134ad09 Compare November 9, 2024 21:38
@larsewi larsewi changed the title WIP: Added librsync to deps-packaging ENT-12414: Added librsync to deps-packaging Nov 9, 2024
@cf-bottom
Copy link

Thanks for submitting a pull request! Maybe @craigcomstock can review this?

@larsewi larsewi force-pushed the librsync branch 9 times, most recently from 570c75a to 51d9180 Compare November 12, 2024 11:59
@larsewi larsewi mentioned this pull request Nov 19, 2024
Merged
5 tasks
@larsewi larsewi force-pushed the librsync branch 2 times, most recently from 82a9cdc to 4a2d8be Compare November 28, 2024 16:42
@larsewi larsewi marked this pull request as ready for review November 29, 2024 09:52
@larsewi larsewi force-pushed the librsync branch 2 times, most recently from b87efce to 9c0100d Compare November 29, 2024 13:12
@larsewi
Copy link
Contributor Author

larsewi commented Nov 29, 2024

@craigcomstock this does not work yet. Any idea what I might be missing or if I did something wrong? To be honest, I don't know what I'm doing 😜

@larsewi
Copy link
Contributor Author

larsewi commented Dec 2, 2024

@craigcomstock this does not work yet. Any idea what I might be missing or if I did something wrong? To be honest, I don't know what I'm doing 😜

@craigcomstock I got a little bit further, so you don't need to help me (yet) 😉

craigcomstock
craigcomstock reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of questions/comments, looks good!

ci/cfengine-build-host-setup.cf Outdated Show resolved Hide resolved
deps-packaging/librsync/cfbuild-librsync.spec Outdated Show resolved Hide resolved
@larsewi larsewi force-pushed the librsync branch 2 times, most recently from a487e74 to b1bc031 Compare December 6, 2024 10:50
@larsewi larsewi force-pushed the librsync branch 2 times, most recently from c78350f to 5c2ac6c Compare December 9, 2024 10:45
@larsewi
Copy link
Contributor Author

larsewi commented Dec 9, 2024

HP-UX failure is probably due to #1546

@larsewi
Added librsync to deps-packaging
ae271bc 
Ticket: ENT-12414
Changelog: None
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
Install librsync dependency on bootstrap host
39139a0 
Ticket: None
Changelog: None
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi merged commit df66392 into cfengine:master Dec 13, 2024
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime left review comments

@craigcomstock craigcomstock craigcomstock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larsewi @cf-bottom @vpodzime @craigcomstock