Updated Configuration to be a new-style class #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had this issue with the saml_cache setting not working as expected as well. |
stevemac007
approved these changes
Feb 14, 2018
There was a problem hiding this comment.
Yep - this works as expected for me now.
I'm working on test coverage to ensure things are managed going forward, unless there are objections I'll merge this in the next 48hrs even without test coverage.
I'd like someone with python3 to confirm this file works in lieu of unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the saml_cache property wasn't working for me (Python 2.7.14 on macos). Some quick googling showed me that you need to use "new-styled" classes.