test: Update tests to latest tytanic spec
#985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tytanicreports nested tests as being deprecated, and eventually ignored in later versions. This PR simply pushes the changes performed bytytanic's ownutil migrate --confirmsubcommands and flag.From skimming the diff, changes only include adding a more fine-grained directory structure and
.gitignorefiles to both theout/anddif/subdirectories of each test, as those contain the resulting output of the test and the diff with the file inref/, respectively.While running tests, I also noticed the
treetest failed. The circles surrounding the areas of the numbers were completely out of place, and it doesn't seem like the test in question has had any major changes in recent commits, so it may be that Typst's internals have modified something in the layout engine of more recent versions (seeing howtytanicdoesn't seem to support Typst compiler versions beyond those of specifictytanicversions [1].) It seems unrelated to CeTZ, but I can't say for sure. What I can say is that the latest commit that changed the reference image for that specific test didn't change thetest.typfile. Simply from observation alone, the resulting reference seems unmodified, but it could be there were some minor positioning changes. Either way, I've tried solving the test, and getting it to look half-decent again, but I've not opened a PR just yet because I'd require also updating the reference withtytanic's corresponding command, and that's just pushing my luck with someone else's project.