plot: Add predefined tick formatters #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
force-pushed
the
predefined-tick-formats
branch
3 times, most recently
from
6b276e8 to
2f32249
Compare
johannes-wolf
commented
Jul 20, 2024
| } | ||
|
|
||
| // Pre-computed table of fractions | ||
| #let _common-denoms = range(2, 11 + 1).map(d => { |
Member
Author
There was a problem hiding this comment.
Idk. about this. It is the simplest solution I came up with and I think if you really want other fractions, it is fine requiring specifying a fixed denominator.
Collaborator
There was a problem hiding this comment.
Is there a reason for 11 + 1 instead of 12?
Member
Author
There was a problem hiding this comment.
To highlight that, we generate fractions up to n/11, not 12 (because range being zero-based).
jamesrswift
approved these changes
Jul 29, 2024
Collaborator
jamesrswift
left a comment
jamesrswift
left a comment
There was a problem hiding this comment.
This looks good to me. Perhaps for a separate PR, it might be worth adding another tick formatter that places the exponent at the top of an axis like so
But this is a nice PR :)
johannes-wolf
force-pushed
the
predefined-tick-formats
branch
from
5839968 to
7ec1298
Compare
johannes-wolf
force-pushed
the
predefined-tick-formats
branch
from
7ec1298 to
33fb6f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new file
formats.typthat defines some tick formatters.fraction: Formatting tick labels as fractionsmultiple-of: Formatting tick labels as a multiple of a constant (e.g. pi)sci: Scientific number formatterI've changed the "lines" gallery entry to some better looking one that show approximations of sin x and uses the new functions.