added struct RequestReply #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 20, 2023 13:52
… safe in the case of recv() being used inside a tokio::select! for example
… safe in the case of recv() being used inside a tokio::select! for example
… safe in the case of recv() being used inside a tokio::select! for example
Owner
|
I think because this is not as safe maybe we should investigate another way to do this. I don't want to introduce a footgun here if there is a cleaner way to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows send() and recv() to be cancel safe : they both take mutable references to the struct
in the case of recv() being used inside a tokio::select! for example
It should probably be specified that this isn't as safe as the RequestSender / RequestReceiver way as you could try to send a multipart before receiving data in the case of the receiver and vice versa.