Refactor HTTP client #3235
Merged
Refactor HTTP client #3235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaprile
requested changes
Aug 12, 2025
tutorials/http/http-client/main.c
Outdated
| @@ -49,24 +50,45 @@ static void fn(struct mg_connection *c, int ev, void *ev_data) { | |||
| // Response is received. Print it | |||
| struct mg_http_message *hm = (struct mg_http_message *) ev_data; | |||
| printf("%.*s", (int) hm->message.len, hm->message.buf); | |||
| c->is_draining = 1; // Tell mongoose to close this connection | |||
| c->is_closing = 1; // Tell mongoose to close this connection | |||
There was a problem hiding this comment.
Nope, c->is_draining is correct.
is_closing produces an immediate close, particularly on our built-in stack, where the closure process is not clean and any pending data could be lost.
The proper way described in our tutorials is to use is_draining
is_closing should only use internally or when deliberately closing on error.
Even though it doesn't make a difference here, we should follow our docs
2b20af3
https://mongoose.ws/documentation/#opening-and-closing-connections
Yes please, take over this ! |
scaprile
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.