Fix dbl printing #2954
Open
Fix dbl printing #2954
+159
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaprile
reviewed
Nov 6, 2024
Comment on lines
+2155
to
+2158
| TESTDOUBLE_NOHOSTCHECK("%g", 0.00001, "0.00001"); // "1e-05" | ||
| TESTDOUBLE("%g", 0.000001, "1e-06"); | ||
| TESTDOUBLE("%g", -0.0001, "-0.0001"); | ||
| TESTDOUBLE_NOHOSTCHECK("%g", -0.00001, "-0.00001"); // "-1e-05" |
There was a problem hiding this comment.
Added these tests.
We "fail" those marked as NOHOSTCHECK as we don't go scientific at 5 decimals
I mean, the host prints "1e-05" and we don't
There was a problem hiding this comment.
The NOHOSTCHECK tests are added cause the result is implementation specific, and not stable across platforms
There was a problem hiding this comment.
I explicitly added those two I'm marking here, please see I added an extra commit to this PR. I did this because I knew we had some issues before and wanted to check.
Those tests I added fail, unless I mark them as NOHOSTCHECK because
AFAICS we are expected to print 1e-05 and yet we print 0.00001
So either we:
- make them work as Linux/? do
- let them as they are until someone complains (if ever)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.